[PATCH] [mips] Expand JAL instructions when PIC is enabled.

Daniel Sanders daniel.sanders at imgtec.com
Fri Jun 12 05:43:40 PDT 2015


In http://reviews.llvm.org/D6231#177071, @tomatabacu wrote:

> I have found a potential fix for the discrepancy between the asm and obj outputs when using .text in a PIC relocation,
>  but I don't have an arch-independent test for it yet and it breaks a lot of NVPTX tests, for some reason.


If it's difficult or a significant amount of work then I'd prefer to get this patch committed and handle that as a follow-up.

Looking back through the comments, I believe the remaining issues are:

- Duplicated nops
- The handling of .text
- Offsets are lost for label+offset

Even without resolving those details this is still a significant step forwards.

Are there any other outstanding issues? If not, I think it's ok to commit whats done so far and fix the smaller details in follow-ups.


http://reviews.llvm.org/D6231

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list