[PATCH] [mips][microMIPS] Implement BREAK, EHB and EI instructions

Zlatko Buljan zlatko.buljan at rt-rk.com
Fri Jun 12 02:38:11 PDT 2015


================
Comment at: lib/Target/Mips/MicroMips32r6InstrFormats.td:229
@@ +228,3 @@
+  let Inst{25-21} = 0x00;
+  let Inst{20-16} = rt;
+  let Inst{15-6}  = funct;
----------------
dsanders wrote:
> Nit: It's called 'rs' in the docs.
I think there is some problem with docs. Tests pass with rt but drops with rs. There is also rt in format class EI_FM_MM in MicroMipsInstrFormats.td. Can you check, please.

http://reviews.llvm.org/D10090

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list