[PATCH] [lld][LinkerScript] Add matching of output sections to segments

Michael Spencer bigcheesegs at gmail.com
Thu Jun 11 14:42:31 PDT 2015


================
Comment at: include/lld/ReaderWriter/LinkerScript.h:1448
@@ +1447,3 @@
+  bool _parsedPHDRS;
+  llvm::StringMap<ErrorOr<std::vector<const PHDR *>>> _sectionToPHDR;
+
----------------
Why are you storing the error here? It should be emitted when the error is encountered. Also, I think that SmallVector<..., 2> would be better here.

http://reviews.llvm.org/D10359

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list