[PATCH] Value profiling compiler-rt changes
Diego Novillo
dnovillo at google.com
Thu Jun 11 13:00:47 PDT 2015
I'd like to see some running commentary on the main instrumentation handler __llvm_profile_instrument_target. Also, tests?
================
Comment at: lib/profile/InstrProfiling.c:139
@@ +138,3 @@
+
+ if (0 == TotalValueDataCount || 0 == TotalValueSiteCount)
+ return 0;
----------------
Slightly prefer to flip the operands in these predicates so the constant is on the RHS. I don't see anything in LLVM's coding guidelines about this, so feel free to ignore.
http://reviews.llvm.org/D9009
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list