[PATCH] Replace string GNU Triples with llvm::Triple in InitMCObjectFileInfo. NFC.

Renato Golin renato.golin at linaro.org
Thu Jun 11 03:28:52 PDT 2015


================
Comment at: lib/MC/MCObjectFileInfo.cpp:757
@@ -755,3 +756,3 @@
 
-  TT = Triple(T);
+  TT = TheTriple;
 
----------------
Can't you just call the argument TT and get rid of this line?

================
Comment at: lib/Target/TargetLoweringObjectFile.cpp:47
@@ -46,3 +46,3 @@
   DL = TM.getDataLayout();
-  InitMCObjectFileInfo(TM.getTargetTriple(),
-                       TM.getRelocationModel(), TM.getCodeModel(), *Ctx);
+  InitMCObjectFileInfo(Triple(TM.getTargetTriple()), TM.getRelocationModel(),
+                       TM.getCodeModel(), *Ctx);
----------------
Didn't getTargetTriple return a Triple after your changes? Or is this before that?

================
Comment at: tools/dsymutil/DwarfLinker.cpp:530
@@ -529,3 +529,3 @@
   MC.reset(new MCContext(MAI.get(), MRI.get(), MOFI.get()));
-  MOFI->InitMCObjectFileInfo(TripleName, Reloc::Default, CodeModel::Default,
-                             *MC);
+  MOFI->InitMCObjectFileInfo(Triple(TripleName), Reloc::Default,
+                             CodeModel::Default, *MC);
----------------
.str()?

================
Comment at: tools/llvm-mc/llvm-mc.cpp:432
@@ -431,3 +431,3 @@
   MCContext Ctx(MAI.get(), MRI.get(), &MOFI, &SrcMgr);
-  MOFI.InitMCObjectFileInfo(TripleName, RelocModel, CMModel, Ctx);
+  MOFI.InitMCObjectFileInfo(Triple(TripleName), RelocModel, CMModel, Ctx);
 
----------------
.str()?

http://reviews.llvm.org/D10366

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list