[PATCH] [CodeGen] Introduce a FAULTING_LOAD_OP pseudo-op.

Andrew Trick atrick at apple.com
Wed Jun 10 23:30:27 PDT 2015


> On Jun 9, 2015, at 6:37 PM, Sanjoy Das <sanjoy at playingwithpointers.com> wrote:
> 
> +For example, Java requires null checks on objects before they are read
> +from or written to.  If the object is ``null`` then a
> +``NullPointerException`` has to be thrown, interrupting normal
> +execution.  In practice, however, dereferencing a ``null`` pointer is
> +extremely rare in well-behaved Java programs, and typically the null
> +check can be folded into a nearby memory operation that operates on
> +the same memory location.
> +
> ----------------
> atrick wrote:
>> Should this be an admonition?
> I don't think I understand -- what should be an admonition?

I’m not a doc style expert and don’t really care if you change this, but I’ve been told in the past that nonessential examples and explanation of the motivation should go in a separate admonition block like

.. admonition:: And by the way…

Andy
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150610/8b6190d7/attachment.html>


More information about the llvm-commits mailing list