[PATCH] [CodeGen] Introduce a FAULTING_LOAD_OP pseudo-op.
Andrew Trick
atrick at apple.com
Tue Jun 9 15:02:54 PDT 2015
Looks good.
================
Comment at: docs/FaultMaps.rst:20-26
@@ +19,9 @@
+
+For example, Java requires null checks on objects before they are read
+from or written to. If the object is ``null`` then a
+``NullPointerException`` has to be thrown, interrupting normal
+execution. In practice, however, dereferencing a ``null`` pointer is
+extremely rare in well-behaved Java programs, and typically the null
+check can be folded into a nearby memory operation that operates on
+the same memory location.
+
----------------
Should this be an admonition?
================
Comment at: docs/FaultMaps.rst:52
@@ +51,3 @@
+ uint32 : FaultingPCOffset
+ uint32 : hnlderPCOffset
+ }
----------------
"Handler"
http://reviews.llvm.org/D10197
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list