[PATCH] [PowerPC]Adapt fast stack unwinding to work for Power.

Bill Seurer seurer at linux.vnet.ibm.com
Mon Jun 8 10:58:20 PDT 2015


On 06/08/2015 11:47 AM, Evgeniy Stepanov wrote:
> On Mon, Jun 8, 2015 at 9:19 AM, Bill Seurer <seurer at linux.vnet.ibm.com> wrote:
>> On 06/05/2015 01:39 PM, Evgeniy Stepanov wrote:
>>>
>>> Also, unless I misunderstand, one your earlier messages (after "On x86
>>> with the stack popping (the code as-is):") seems to suggest that this
>>> code breaks x86 tests?
>>
>>
>> No, this change doesn't affect X86.
>>
>> My comment was about when I tried disabling the popping of extra frames on
>> X86 to see what it was actually popping because it too uses the "pop the
>> stack until you get to PC" code in the fast unwinder.
>
> Sorry, are you saying that the current code in the fast unwinder pops
> frames off the top of the stack trace? I don't see anything like that
> in my checkout. Could you point to the exact code line please?

I looked back to see what I did with that X86 test and I disabled the 
popping in the slow unwinder, not fast, to see what it was removing as 
compared to what was being done for power.

In any case this change does not affect anyone other than powerpc.
-- 

-Bill Seurer




More information about the llvm-commits mailing list