[llvm] r239317 - Make flags get/set method protected so that all flags have to be managed by subclasses.

Pete Cooper peter_cooper at apple.com
Mon Jun 8 10:17:31 PDT 2015


Author: pete
Date: Mon Jun  8 12:17:30 2015
New Revision: 239317

URL: http://llvm.org/viewvc/llvm-project?rev=239317&view=rev
Log:
Make flags get/set method protected so that all flags have to be managed by subclasses.

All of ELF, COFF and MachO now manipulate the flags in helpers so we don't need
anyone to read the flags directly, but instead via those helpers.

Reviewed by Rafael EspĂ­ndola.

Modified:
    llvm/trunk/include/llvm/MC/MCSymbol.h

Modified: llvm/trunk/include/llvm/MC/MCSymbol.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/MC/MCSymbol.h?rev=239317&r1=239316&r2=239317&view=diff
==============================================================================
--- llvm/trunk/include/llvm/MC/MCSymbol.h (original)
+++ llvm/trunk/include/llvm/MC/MCSymbol.h Mon Jun  8 12:17:30 2015
@@ -290,17 +290,6 @@ public:
   /// Is this a 'common' symbol.
   bool isCommon() const { return CommonAlign != -1U; }
 
-  /// Get the (implementation defined) symbol flags.
-  uint32_t getFlags() const { return Flags; }
-
-  /// Set the (implementation defined) symbol flags.
-  void setFlags(uint32_t Value) const { Flags = Value; }
-
-  /// Modify the flags via a mask
-  void modifyFlags(uint32_t Value, uint32_t Mask) const {
-    Flags = (Flags & ~Mask) | Value;
-  }
-
   MCFragment *getFragment() const {
     if (!HasFragment)
       return nullptr;
@@ -322,6 +311,18 @@ public:
 
   /// dump - Print the value to stderr.
   void dump() const;
+
+protected:
+  /// Get the (implementation defined) symbol flags.
+  uint32_t getFlags() const { return Flags; }
+
+  /// Set the (implementation defined) symbol flags.
+  void setFlags(uint32_t Value) const { Flags = Value; }
+
+  /// Modify the flags via a mask
+  void modifyFlags(uint32_t Value, uint32_t Mask) const {
+    Flags = (Flags & ~Mask) | Value;
+  }
 };
 
 inline raw_ostream &operator<<(raw_ostream &OS, const MCSymbol &Sym) {






More information about the llvm-commits mailing list