[PATCH] [DWARF] Fix a few corner cases in expression emission

Keno Fischer kfischer at college.harvard.edu
Sun Jun 7 22:11:07 PDT 2015


Hi echristo, aprantl, dblaikie,

I noticed an object file with `DW_OP_reg4 DW_OP_breg4 0` as a DWARF expression, which I traced to a missing break (and `++I`) in this code snippet. While I was at it, I also added support for a few other corner cases along the same lines that I could think of. Please have a look - I've read the DWARF spec, but am I by no means an expert.

REPOSITORY
  rL LLVM

http://reviews.llvm.org/D10302

Files:
  lib/CodeGen/AsmPrinter/DwarfDebug.cpp
  lib/CodeGen/AsmPrinter/DwarfExpression.cpp
  lib/CodeGen/AsmPrinter/DwarfExpression.h
  test/DebugInfo/expressions.ll

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D10302.27277.patch
Type: text/x-patch
Size: 10655 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150608/45969d79/attachment.bin>


More information about the llvm-commits mailing list