[PATCH] llvm-ar: Move archive writer to Object.

Rafael Ávila de Espíndola rafael.espindola at gmail.com
Sat Jun 6 20:17:22 PDT 2015


We really need a better way of handling diagnostics in lib/Object, but this is fine for now with some nits.

I will try to code something to untangle diagnostics and error handling in general.


================
Comment at: include/llvm/Object/ArchiveWriter.h:10
@@ +9,3 @@
+//
+// Declares the WriteArchive function for writing an archive file.
+//
----------------
writeArchive.

================
Comment at: lib/Object/ArchiveWriter.cpp:92
@@ +91,3 @@
+
+static void print32BE(raw_fd_ostream &Out, unsigned Val) {
+  for (int I = 3; I >= 0; --I) {
----------------
Please add a FIXME about using endian.h

http://reviews.llvm.org/D10296

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list