[PATCH] Remove SCEVCache and FindConstantPointers from complete loop unrolling heuristic.

Chandler Carruth chandlerc at gmail.com
Fri Jun 5 23:10:16 PDT 2015


See below before committing please.


================
Comment at: lib/Transforms/Scalar/LoopUnrollPass.cpp:387
@@ +386,3 @@
+    if (!isa<Constant>(LHS) && !isa<Constant>(RHS))
+      if (!simplifyUsingOffsets(LHS, RHS))
+        return Base::visitBinaryOperator(I);
----------------
mzolotukhin wrote:
> chandlerc wrote:
> > Where is this defined?
> Oops, it crept to the subsequent patch (D10206). I'll move it to this one before committing, but do you mind taking a glance there too?
Please commit *without* this change.

I don't think simplifyUsingOffsets is the right approach (as handled in D10206), and I'd rather not hold the rest of this up on that review.

http://reviews.llvm.org/D10205

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list