[PATCH] Set a debugger "target" to guide DWARF choices

Paul Robinson Paul_Robinson at playstation.sony.com
Fri Jun 5 12:35:41 PDT 2015


Refresh and address specific review comments:

- pubsections based on tuning for GDB (this is correct only if "no tuning" isn't an option)
- revert TLS opcode choice to platform-based instead of tuning-based; Eric and Adrian need to work that one out, right now I'm following the most recent expressed wish of the code owner even though I agree with Adrian
- move test to a separate file
- setting the default tuning remains triple-based; changing the defaults for other targets can wait for follow-up patches

I did experiment with "default to no tuning."  While tests basically
worked, it exposed one minor flaw in dwarf-public-names.ll (diff
included here although it really ought to be committed separately).
However, a no-tuning default would be a distinct functional change,
not backward compatible, as pointed out by David Blaikie; so I didn't
do that in the patch.

We might still want to have a more Target-based way to specify a
default tuning, rather than using the triple, but that could be a
followup patch. Note that people associated with FreeBSD and with
Hexagon have both expressed a desire to default to LLDB.


http://reviews.llvm.org/D8506

Files:
  include/llvm/CodeGen/CommandFlags.h
  include/llvm/Target/TargetOptions.h
  lib/CodeGen/AsmPrinter/DwarfDebug.cpp
  lib/CodeGen/AsmPrinter/DwarfDebug.h
  test/DebugInfo/X86/debugger-tune.ll
  test/DebugInfo/X86/dwarf-public-names.ll

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D8506.27218.patch
Type: text/x-patch
Size: 8138 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150605/f0678b1f/attachment.bin>


More information about the llvm-commits mailing list