[llvm] r239172 - [InstCombine][NFC] Add a ``break;`` statement.

Sanjoy Das sanjoy at playingwithpointers.com
Fri Jun 5 11:04:47 PDT 2015


Author: sanjoy
Date: Fri Jun  5 13:04:46 2015
New Revision: 239172

URL: http://llvm.org/viewvc/llvm-project?rev=239172&view=rev
Log:
[InstCombine][NFC] Add a ``break;`` statement.

This change is NFC because both the ``break;`` and the fall through end
up returning immediately. However, this helps clarify intent and also
ensures correctness in case more ``case`` blocks are added later.

Modified:
    llvm/trunk/lib/Transforms/InstCombine/InstCombineCompares.cpp

Modified: llvm/trunk/lib/Transforms/InstCombine/InstCombineCompares.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/InstCombine/InstCombineCompares.cpp?rev=239172&r1=239171&r2=239172&view=diff
==============================================================================
--- llvm/trunk/lib/Transforms/InstCombine/InstCombineCompares.cpp (original)
+++ llvm/trunk/lib/Transforms/InstCombine/InstCombineCompares.cpp Fri Jun  5 13:04:46 2015
@@ -2195,6 +2195,7 @@ bool InstCombiner::OptimizeOverflowCheck
       if (WillNotOverflowSignedMul(LHS, RHS, OrigI))
         return SetResult(Builder->CreateNSWMul(LHS, RHS), Builder->getFalse(),
                          true);
+    break;
   }
 
   return false;





More information about the llvm-commits mailing list