[PATCH] [LoopVectorize]Teach Loop Vectorizer about interleaved memory access

Michael Zolotukhin mzolotukhin at apple.com
Thu Jun 4 15:54:09 PDT 2015


Hi,

I’m glad we’re on the same page now. I’m really looking forward to seeing this feature, but I didn’t want to rush with it because it strongly defines directions for future development of the vectorizer. I believe that this code would be a base for many other optimizations (e.g. supporting masks), and that’s why it’s really important for it to be thoroughly reviewed. That’s also a reason for a lot of cosmetic changes I requested - when I see a place that’s harder to understand than it should be, I have to spend additional time on it, and that means that in future many other developers would have to spend their time as well. Also, such places disrupt from the main idea, which makes the review harder.

Thanks,
Michael

> On Jun 4, 2015, at 2:55 PM, Adam Nemet <anemet at apple.com> wrote:
> 
> In http://reviews.llvm.org/D9368#183726, @rengolin wrote:
> 
>> I just interpreted the last reviews as specific to the stride vectorizer, when (as you say), they're generic to LAA. My sincere apologies.
> 
> 
> OK, apologies accepted :), thanks for clarifying.
> 
> I think that part of the problem is that LAA as an independent pass still has some rough edges.  Any help (Hao’s here and Silviu’s in the other thread) improving this situation is much appreciated.
> 
> Adam
> 
> 
> http://reviews.llvm.org/D9368
> 
> EMAIL PREFERENCES
>  http://reviews.llvm.org/settings/panel/emailpreferences/
> 
> 





More information about the llvm-commits mailing list