[PATCH] [sanitizer_common] Added VS-style output for source locations

Reid Kleckner rnk at google.com
Thu Jun 4 14:57:12 PDT 2015


REPOSITORY
  rL LLVM

================
Comment at: lib/sanitizer_common/sanitizer_flags.inc:149
@@ -148,1 +148,3 @@
             "Print inlined frames in stacktraces. Defaults to true.")
+COMMON_FLAG(bool, symbolize_vs_style, false,
+            "Print file locations in Visual Studio style (e.g: "
----------------
samsonov wrote:
> filcab wrote:
> > This should probably default to SANITIZER_WINDOWS instead of false.
> > I think it would be the option that better matches what a user of that platform would expect, no?
> I'd let Reid comment on this. I don't have strong preference about Windows defaults.
Let's default this to `defined(_MSC_VER)`. Thankfully it is very easy to override the default sanitizer options with __asan_default_options(), so I'd rather optimize for first time users of visual studio rather than people like us with big cross-platform projects.

http://reviews.llvm.org/D10113

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list