[llvm] r239071 - [bpf] add big- and host- endian support

Quentin Colombet qcolombet at apple.com
Thu Jun 4 14:17:23 PDT 2015


> On Jun 4, 2015, at 2:12 PM, Alexei Starovoitov <alexei.starovoitov at gmail.com> wrote:
> 
> On Thu, Jun 4, 2015 at 2:09 PM, Quentin Colombet <qcolombet at apple.com> wrote:
>> 
>> On Jun 4, 2015, at 1:53 PM, Alexei Starovoitov
>> <alexei.starovoitov at gmail.com> wrote:
>> 
>> On Thu, Jun 4, 2015 at 12:24 PM, Eric Christopher <echristo at gmail.com>
>> wrote:
>> 
>> It doesn't look like anyone actually approved this? (I know, it was in my
>> list of things to look at :)
>> 
>> 
>> nope. It started to bit rot too quickly, so I pushed it.
>> 
>> 
>> Please don’t do that. Unless I am mistaken, the review was out only for a
>> couple of days.
>> Here is the review policy, if you want more information.
>> http://llvm.org/docs/DeveloperPolicy.html#code-reviews
> 
> hmm, I'm exactly doing the following part:
> "(or changes where the developer owns the component) can be reviewed
> after commit."

Well, in that case, don’t post a review request in the first place :).

Q.



More information about the llvm-commits mailing list