[PATCH] Simplify ARMTargetParser::getArchSynonym
Renato Golin
renato.golin at linaro.org
Thu Jun 4 13:57:50 PDT 2015
There are also lots of places that are calling parseArch(getCanonical()), can you simplify them as well?
Some of them are in Clang...
REPOSITORY
rL LLVM
================
Comment at: lib/Support/TargetParser.cpp:371
@@ -372,2 +370,3 @@
unsigned ARMTargetParser::parseArch(StringRef Arch) {
+ Arch = getCanonicalArchName(Arch);
StringRef Syn = getArchSynonym(Arch);
----------------
The reason why I didn't do this initially is because I was calling parseArch() inside getCanonicalArchName(). Now this is safe, thanks for fixing this.
http://reviews.llvm.org/D10249
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list