[PATCH] [LAA] Fix estimation of number of memchecks

Adam Nemet anemet at apple.com
Thu Jun 4 12:35:43 PDT 2015


Very nice!  LGTM.


================
Comment at: lib/Analysis/LoopAccessAnalysis.cpp:1129-1132
@@ -1134,4 +1128,6 @@
+                                          TheLoop, Strides);
+  unsigned NumComparisons = PtrRtCheck.getNumberOfChecks(nullptr);
 
   DEBUG(dbgs() << "LAA: We need to do " << NumComparisons <<
         " pointer comparisons.\n");
 
----------------
Looks like you only use NumComparison in the DEBUG message now.  With a release compiler this will probably give you a warning.

http://reviews.llvm.org/D10217

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list