[PATCH] Add per-test timeouts to lit

Eric Fiselier eric at efcs.ca
Thu Jun 4 11:23:48 PDT 2015


Other than the inline comment this LGTM but I'll let @ddunbar give it the thumbs up.


================
Comment at: utils/lit/lit/util.py:83
@@ +82,3 @@
+            self.kill()
+            raise value
+        self.cancel()
----------------
It is incorrect to re-raise the passed in exception.
https://docs.python.org/2/reference/datamodel.html#object.__exit__

http://reviews.llvm.org/D6584

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list