[PATCH] [ARM] Add knowledge of FPU subtarget features to TargetParser

John Brawn john.brawn at arm.com
Thu Jun 4 08:54:59 PDT 2015


In http://reviews.llvm.org/D10237#183519, @rengolin wrote:

> What about moving it to Triple?


That would be a bit of an odd place to do it, as FPUs and triples only indirectly have anything to do with each other - a triple may indirectly cause a default FPU due to the default CPU, but there's no link in the FPU->Triple direction.

It's not clear to my why TargetParser isn't the right place for this. You say "The overall design of this class must be as simple as possible", but I don't see why that is. My impression of TargetParser is that it handles target-specific names in a way that means the thing using it doesn't need target-specific information, e.g. you can go from architecture name to default CPU name without needing to know what those names mean. Going from FPU name to a list of subtarget feature flags doesn't seem that different to me.


REPOSITORY
  rL LLVM

http://reviews.llvm.org/D10237

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list