[PATCH] [mips] [IAS] Restore STI.FeatureBits in .set pop.

Daniel Sanders daniel.sanders at imgtec.com
Thu Jun 4 07:24:42 PDT 2015


LGTM


================
Comment at: lib/Target/Mips/AsmParser/MipsAsmParser.cpp:46
@@ -45,3 +45,3 @@
 public:
-  MipsAssemblerOptions(uint64_t Features_) : 
+  MipsAssemblerOptions(const FeatureBitset& Features_) :
     ATReg(1), Reorder(true), Macro(true), Features(Features_) {}
----------------
Nit: Space goes before the '&' rather than after.

================
Comment at: lib/Target/Mips/AsmParser/MipsAsmParser.cpp:74
@@ -75,1 +73,3 @@
+  const FeatureBitset &getFeatures() const { return Features; }
+  void setFeatures(const FeatureBitset& Features_) { Features = Features_; }
 
----------------
Nit: Here too.

http://reviews.llvm.org/D9156

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list