[PATCH] [Object, MachO] Don't crash on invalid MachO load commands.

Filipe Cabecinhas filcab+llvm.phabricator at gmail.com
Wed Jun 3 18:30:51 PDT 2015


================
Comment at: test/Object/macho-invalid.test:4
@@ -3,3 +3,3 @@
 
-RUN: not llvm-objdump -private-headers %p/Inputs/macho64-invalid-incomplete-load-command 2>&1 \
+RUN: llvm-objdump -private-headers %p/Inputs/macho64-invalid-incomplete-load-command 2>&1 \
 RUN:      | FileCheck -check-prefix INCOMPLETE-LOADC %s
----------------
Please commit this formatting change separately, then add the case for this patch.

================
Comment at: test/Object/macho-invalid.test:6
@@ -5,2 +5,3 @@
 RUN:      | FileCheck -check-prefix INCOMPLETE-LOADC %s
+INCOMPLETE-LOADC: Invalid data was encountered while parsing the file.
 
----------------
Please commit this formatting change separately (for all the previous tests), then do the patch for this case, removing the "not".

http://reviews.llvm.org/D10230

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list