[PATCH] [Object, MachO] Don't crash on parsing invalid MachO header.

Alexey Samsonov vonosmas at gmail.com
Wed Jun 3 17:32:36 PDT 2015


================
Comment at: test/Object/macho-invalid.test:41
@@ -38,1 +40,2 @@
 INVALID-SECTION-IDX-SYMBOL-SEC: getSymbolSection: Invalid section index
+INVALID-HEADER: Invalid data was encountered while parsing the file.
----------------
filcab wrote:
> If you're expecting to add a lot of these, we might want to start putting the expected error next to the respective run line, instead of all the run lines and then all the errors.
> (Both are ok with me, we can also wait until it gets unreadable and then change)
Right, I'm addressing this in subsequent http://reviews.llvm.org/D10230

http://reviews.llvm.org/D10227

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list