[PATCH] [PM/AA] Start refactoring AliasAnalysis to remove the analysis group and port it to the new pass manager.
hfinkel at anl.gov
hfinkel at anl.gov
Wed Jun 3 17:00:27 PDT 2015
LGTM.
================
Comment at: include/llvm/Analysis/MemoryLocation.h:38
@@ +37,3 @@
+/// The primary user of this interface is LLVM's Alias Analysis, but other
+/// memory analyses such as MemoryDependence and (eventually) MemorySSA will
+/// all use it.
----------------
I'd rather not mention MemorySSA here, just in case is does not end up having that name, and we forget to update it.
================
Comment at: lib/Transforms/Scalar/MemCpyOptimizer.cpp:815
@@ -814,3 +814,3 @@
bool UseMemMove = false;
- if (!AA.isNoAlias(AA.getLocationForDest(M), AA.getLocationForSource(MDep)))
+ if (!AA.isNoAlias(MemoryLocation::getForDest(M), MemoryLocation::getForSource(MDep)))
UseMemMove = true;
----------------
Indentation looks odd here.
http://reviews.llvm.org/D10228
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list