[PATCH] [Object, MachO] Cache parsed MachO header in MachOObjectFile. NFC.

Filipe Cabecinhas filcab+llvm.phabricator at gmail.com
Wed Jun 3 16:50:41 PDT 2015


LGTM.

I'd probably like a comment pointing out that it works because all the (used) members of mach_header and mach_header64 match in size and location.
For people reading the code who aren't familiar with how those headers look, the MachOObjectFile constructor might look weird. (Not a strong want, but I think it might help readability)

Thanks


http://reviews.llvm.org/D10226

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list