[llvm] r238915 - Re-commit r238838, r238844 with fix for host/target endian mismatch and windows buildbot.

[Daniel Sanders]

Hi,

I've just seen your emails. Thanks for finding and fixing the incidental breakage.

> I do wonder why we're even attempting to register non-native
> .eh_frames, because I think the object file is probably fine.

I might be missing something but registration shouldn't be a problem so long as we don't try to execute the the foreign code. These tests stop at the point we'd normally start executing the object and inspect memory to ensure that the relocations happened correctly.

Just to mention it: The host/target endian mismatch bug should be present in most of the targets (reinterpret_cast<uint32_t*> appears a lot) but aren't revealed by the current set of tests.

________________________________________
From: Tim Northover [t.p.northover at gmail.com]
Sent: 03 June 2015 20:59
To: Daniel Sanders
Cc: llvm-commits
Subject: Re: [llvm] r238915 - Re-commit r238838, r238844 with fix for host/target endian mismatch and windows buildbot.

On 3 June 2015 at 11:23, Tim Northover <t.p.northover at gmail.com> wrote:
> Never mind I think we've decided it was incidental breakage and I'm
> working on a fix now.

Looks like it's green again with r238858.

Tim.