[PATCH] Optimize scattered vector insert/extract pattern

Nadav Rotem nrotem at apple.com
Tue Jun 2 12:57:16 PDT 2015


Hi Lawrence, 

The SLP vectorizer already supports collecting trees that start at insertElement (see  “findBuildVector”), and definitely supports trees that start at stores. It looks like you are adding special handling for these instructions just to work around the cost model, which is the wrong way of implementing vectorization of insert/extract instructions. Did you look into the code that calculates the cost of vector zext/sext? 

-Nadav



> On Jun 2, 2015, at 10:12 AM, Lawrence Hu <lawrence at codeaurora.org> wrote:
> 
> ping
> 
> 
> REPOSITORY
>  rL LLVM
> 
> http://reviews.llvm.org/D9804
> 
> EMAIL PREFERENCES
>  http://reviews.llvm.org/settings/panel/emailpreferences/
> 
> 





More information about the llvm-commits mailing list