[PATCH] [mips] Add RuntimeDyld tests for currently supported O32 relocations.

Vasileios Kalintiris Vasileios.Kalintiris at imgtec.com
Tue Jun 2 05:06:04 PDT 2015


LGTM


================
Comment at: test/ExecutionEngine/RuntimeDyld/Mips/ELF_O32_PIC_relocations.s:3
@@ +2,3 @@
+# RUN: llc -mtriple=mipsel-unknown-linux -relocation-model=pic -filetype=obj -o %T/test_ELF_ExternalFunction_O32.o %S/Inputs/ExternalFunction.ll
+# RUN: llvm-rtdyld -triple=mipsel-unknown-linux -verify -map-section test_ELF_O32.o,.text=0x1000 -map-section test_ELF_ExternalFunction_O32.o,.text=0x10000 -check=%s %/T/test_ELF_O32.o %T/test_ELF_ExternalFunction_O32.o
+
----------------
change %/T to %T in order to be consistent and avoid needless canonicalization.

================
Comment at: test/ExecutionEngine/RuntimeDyld/Mips/ELF_O32_PIC_relocations.s:5-7
@@ +4,5 @@
+
+# R!N: llvm-mc -triple=mips-unknown-linux -relocation-model=pic -code-model=small -filetype=obj -o %T/test_ELF_O32.o %s
+# R!N: llc -mtriple=mips-unknown-linux -relocation-model=pic -filetype=obj -o %T/test_ELF_ExternalFunction_O32.o %S/Inputs/ExternalFunction.ll
+# R!N: llvm-rtdyld -triple=mips-unknown-linux -verify -map-section test_ELF_O32.o,.text=0x1000 -map-section test_ELF_ExternalFunction_O32.o,.text=0x10000 -check=%s %/T/test_ELF_O32.o %T/test_ELF_ExternalFunction_O32.o
+
----------------
Do we want to keep these lines (disabled) for future reference?

http://reviews.llvm.org/D10126

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list