[PATCH] [mips] [IAS] Restore STI.FeatureBits in .set pop.

Daniel Sanders daniel.sanders at imgtec.com
Mon Jun 1 06:01:11 PDT 2015


LGTM with an extended test case to cover '.set pop' enabling a feature that was indirectly disabled inside a .set push/pop region.


================
Comment at: test/MC/Mips/set-push-pop-directives.s:70
@@ +69,2 @@
+# CHECK-NOT: :[[@LINE-1]]:5: error: instruction requires a CPU feature not currently enabled
+    .set pop
----------------
We ought to add a test like:
  .set msa
  .set push
  .set mips32 # MSA not available in MIPS32
  addvi.b $w1, $w2, 1 # CHECK: :[[@LINE-1]]:5: error: instruction requires a CPU feature not currently enabled
  .set pop
  addvi.b $w1, $w2, 1 # CHECK-NOT: :[[@LINE-1]]:5: error: instruction requires a CPU feature not currently enabled

http://reviews.llvm.org/D9156

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list