[PATCH] [Object, MachO] Introduce MachOObjectFile::load_commands() range iterator.

Alexey Samsonov vonosmas at gmail.com
Fri May 29 18:34:34 PDT 2015


Wait a second, this is stupid. We're walking through all load commands in the constructor and fail to create an object if another command can't be parsed. We should just cache all the load commands in a vector, and get rid of all this ErrorOr<> stuff. I'll update the patch shortly, sorry for noise.


http://reviews.llvm.org/D10144

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list