[PATCH] LivePhysRegs: Add support to add pristine registers when populating with live-in/live-out registers.

Quentin Colombet qcolombet at apple.com
Fri May 29 16:26:00 PDT 2015


I agree, the error proneness is a good argument!

Small comments inlined.

Cheers,
-Quentin


REPOSITORY
  rL LLVM

================
Comment at: lib/CodeGen/LivePhysRegs.cpp:140
@@ +139,3 @@
+  const MachineFrameInfo &MFI = *MF.getFrameInfo();
+  if (!MFI.isCalleeSavedInfoValid())
+    return;
----------------
Is there a reason we are not using MachineFrameInfo::getPristineRegs?

I may be wrong, but at first glance it seems as if we copied/pasted the code from there.

http://reviews.llvm.org/D10139

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list