[PATCH] [llvm] Let Intrinsics.h depend only on the relevant part of Intrinsics.gen (NFC, part of the fix for bug#11951)

Reid Kleckner rnk at google.com
Fri May 29 13:40:20 PDT 2015


In http://reviews.llvm.org/D10073#181161, @leon wrote:

> I have considered that possibility (and mentioned it at 
>  http://reviews.llvm.org/D10073), but in my humble opinion enhancing 
>  tblgen's interface with additional named generators for finer-grained 
>  control over intrinsics generation wouldn't be the right decision.


Consider that every target essentially starts from Arch.td and generates many different kinds of tables (assembler maps, disassembler maps, SDAG state machines, etc). This is a pretty common pattern already, so it seems better to be consistent and not add more tools for source code generation than we already have. The CMake logic for controlling them is ugly and hard to get right across multiple generators, but we already have it wrapped up and abstracted for tablegen.


REPOSITORY
  rL LLVM

http://reviews.llvm.org/D10073

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list