[PATCH] [lld] [ELF/Aarch64 v2] Fix correct TCB aligment calculation

Adhemerval Zanella adhemerval.zanella at linaro.org
Fri May 29 06:21:47 PDT 2015


Hi ruiu, shankar.easwaran,


This is an updated patch and it fixes the TLS local relocations alignment
done by @238258. As pointed out, the TLS size should not be considered,
but rather the TCB size based on maximum output segment alignment. 
Although it has not shown in the TLS simple cases for test-suite, more
comprehensible tests with more local TLS variable showed wrong relocations 
values being generated.

The local TLS testcase is expanded to add more tls variable (both
exported and static) initialized or not.

Differences from first version:

* Using C++11 initialization mechanism for _tpOff
* Only considering TLS segments for TCB alignment
* Remove some 'auto' usage.

http://reviews.llvm.org/D10121

Files:
  lib/ReaderWriter/ELF/AArch64/AArch64RelocationHandler.cpp
  lib/ReaderWriter/ELF/AArch64/AArch64RelocationHandler.h
  lib/ReaderWriter/ELF/AArch64/AArch64TargetHandler.h
  test/elf/AArch64/local-tls.test

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D10121.26779.patch
Type: text/x-patch
Size: 11526 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150529/31b9cd7e/attachment.bin>


More information about the llvm-commits mailing list