[PATCH] [Object, MachO] Make MachO parser significantly more robust to invalid inputs.

Alexey Samsonov vonosmas at gmail.com
Thu May 28 17:40:19 PDT 2015


In http://reviews.llvm.org/D10111#180753, @loladiro wrote:

> Would it be sensible to use ErrorOr instead of adding an out parameter?


`std::error_code` is consistent with ObjectFile interface. See `include/llvm/Object/ObjectFile.h`: we use `std::error_code` in accessors like `ObjectFile::getSymbolAddress()`, and only use `ErrorOr` in factories.


http://reviews.llvm.org/D10111

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list