[PATCH] [Object, MachO] Make MachO parser significantly more robust to invalid inputs.

Alexey Samsonov vonosmas at gmail.com
Thu May 28 16:55:57 PDT 2015


Hi rafael, loladiro, lhames,

In general, assume that parsing MachO command may fail: make a large
family of methods return std::error_code instead of returning MachO
commands by value.

This is a significant API change. For now I've just converted MachO
parser implementation, and will proceed with converting the callers if
this direction is approved.

This change is a part of ongoing effort to use LibFuzzer to test LLVM
object parsing/dumping machinery, see r238451 that adds
llvm-dwarfdump-fuzzer, for instance.

http://reviews.llvm.org/D10111

Files:
  include/llvm/Object/MachO.h
  lib/Object/MachOObjectFile.cpp

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D10111.26754.patch
Type: text/x-patch
Size: 55059 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150528/39e83012/attachment.bin>


More information about the llvm-commits mailing list