[PATCH] [InstCombine] Fold bitcasts into loads across PHINodes

Chandler Carruth chandlerc at gmail.com
Thu May 28 14:32:27 PDT 2015


The idea here makes total sense to me, but I don't think this is the right way to do it.

I think you should be combining the PHI or cast, not the load. The combine should be to hoist a cast of a PHI around the PHI if all of the PHI inputs are casts and loads. You might also need to enqueue the loads in the combiner afterward so we revisit them and recognize that we can fold the cast into the load.


REPOSITORY
  rL LLVM

http://reviews.llvm.org/D9500

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list