[PATCH] [IR/AsmWriter] Output escape sequences if the first character isdigit()

Duncan P. N. Exon Smith dexonsmith at apple.com
Thu May 28 11:12:48 PDT 2015


> On 2015-May-27, at 18:06, Filipe Cabecinhas <filcab+llvm.phabricator at gmail.com> wrote:
> 
> I could add some more stuff to FileCheck in that test, but am not 100% sure on what the best way to do it.
> 
> If it's safe to assume the output it currently has (!{} becomes !2, and some other "abbreviations" appear), I can do a verbatim check, but it would basically be checking copy+paste.
> Comments on this?

Output is deterministic so you can rely on it staying the same,
but it's awkward when it's hard to predict by reading the file.

It might be easiest just to add a fresh (verbatim) test in
test/Assembler, maybe metadata-escaped-attachment-names.ll?

If you do that (and satisfy Rafael), LGTM.

> 
> 
> http://reviews.llvm.org/D10079
> 
> EMAIL PREFERENCES
>  http://reviews.llvm.org/settings/panel/emailpreferences/
> 
> 





More information about the llvm-commits mailing list