[PATCH] Minor refactoring of GEP handling in isDereferenceablePointer

Philip Reames listmail at philipreames.com
Thu May 28 11:04:24 PDT 2015


Artur, I'm a bit confused on what this code is trying to accomplish.  First, is this intended to be an NFC change?  If not, where's the test case?

It appears like this is basically trying to infer the "inbounds" property on GEPs.  I'm sure we have some code for this in InstCombine, have you looked there to see what it does?  Having a function of the form isInboundsGEP(GetElementPointer *GEP) which is used from both places might be a good factoring.


http://reviews.llvm.org/D9874

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list