[PATCH] Enable debugger support

[Malysheva, Olga]

Hello!

Thank you for your comment. We'll add more comments for this code.

1. __kmp_debugging can be set by a debugger to notify OpenMP RTL that it is run under the debugger. 

2. The ident parameter is used in __kmp_omp_num_threads() function to check if the number of threads was changed by the debugger for the parallel which location was specified by the ident. 
Please, see usage of __kmp_omp_num_threads() (together with __kmp_debugging) in __kmp_fork_call() function.

Currently, Intel Debugger (IDB) is supported. 

Regards,
Olga

-----Original Message-----
From: hfinkel at anl.gov [mailto:hfinkel at anl.gov] 
Sent: Wednesday, May 27, 2015 8:48 PM
To: Peyton, Jonathan L; hfinkel at anl.gov
Cc: Malysheva, Olga; llvm-commits at cs.uiuc.edu; openmp-commits at dcs-maillist2.engr.illinois.edu
Subject: Re: [PATCH] Enable debugger support




REPOSITORY
  rL LLVM

================
Comment at: runtime/src/kmp_debugger.h:24 @@ +23,3 @@
+
+extern int __kmp_debugging;             /* Boolean whether currently debugging OpenMP RTL */
+// Return number of threads specified by the debugger for given parallel region.
----------------
Please document how, by whom, and when this can be set.

================
Comment at: runtime/src/kmp_debugger.h:26 @@ +25,3 @@
+// Return number of threads specified by the debugger for given parallel region.
+int __kmp_omp_num_threads( ident_t const * ident );
+
----------------
How is the ident parameter used? (please document that)

http://reviews.llvm.org/D10038

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/



--------------------------------------------------------------------
Closed Joint Stock Company Intel A/O
Registered legal address: Krylatsky Hills Business Park, 
17 Krylatskaya Str., Bldg 4, Moscow 121614, 
Russian Federation

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.