[PATCH] [mips] Add new format for dmtc2/dmfc2 for Octeon CPUs.
Daniel Sanders
daniel.sanders at imgtec.com
Thu May 28 02:15:19 PDT 2015
LGTM with a nit.
Just to check: Is the decoder conflict something that happens now (I couldn't reproduce it) or are you accounting for MIPS64 dmfc2/dmtc2's conflicting when they are added?
================
Comment at: lib/Target/Mips/Disassembler/MipsDisassembler.cpp:897
@@ +896,3 @@
+ Result = decodeInstruction(DecoderTableCnMips32, Instr, Insn,
+ Address, this, STI);
+ if (Result != MCDisassembler::Fail) {
----------------
Nit: Indentation, should line up with the 'D' in DecoderTableCnMips32.
http://reviews.llvm.org/D10083
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list