[PATCH] [RuntimeDyld] Adapt PPC64 relocations to PPC32
hfinkel at anl.gov
hfinkel at anl.gov
Wed May 27 11:54:36 PDT 2015
> I don't know how the JIT is tested for the PPC target. There only seem to be X86 and ARM tests in test/ExecutionEngine/RuntimeDyld
That's not good. The generic MCJIT tests are run on PPC64, but otherwise I don't know.
Can you please add a test for this patch (in test/ExecutionEngine/RuntimeDyld sounds good if that's easiest) -- (just remember that the new directory needs a lit.local.cfg file, like the others, that tests for 'PowerPC').
REPOSITORY
rL LLVM
================
Comment at: lib/ExecutionEngine/RuntimeDyld/RuntimeDyldELF.cpp:658
@@ +657,3 @@
+ case ELF::R_PPC_REL32:
+ if (SignExtend32<32>(delta) != delta)
+ llvm_unreachable("Relocation R_PPC_REL32 overflow");
----------------
This can be isInt<32>(delta).
http://reviews.llvm.org/D9998
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list