[PATCH] libunwind cannot be used in C programs due to __cxxabi_config.h include
Oleg Ranevskyy
llvm.mail.list at gmail.com
Wed May 27 13:40:05 PDT 2015
REPOSITORY
rL LLVM
================
Comment at: include/libunwind_config.h:15
@@ +14,3 @@
+ !defined(__ARM_DWARF_EH__)
+#define LIBCXXABI_ARM_EHABI 1
+#else
----------------
asl wrote:
> Should we use LIBUNWIND_ARM_EHABI here and everywhere below?
Yes, this sounds reasonable.
However, my thought behind leaving it same-named is that if anyone decides to change the conditions when LIBCXXABI_ARM_EHABI is defined, it could be helpful to see the change can and should affect libunwind, since the meaning of LIBCXXABI_ARM_EHABI and LIBUNWIND_ARM_EHABI is the same. One will find all the dependent logic by searching the code for LIBCXXABI_ARM_EHABI.
Please let me know if the name is to be changed anyway.
http://reviews.llvm.org/D9915
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list