Fix PR 23499

Justin Bogner mail at justinbogner.com
Wed May 27 09:32:02 PDT 2015


Diego Novillo <dnovillo at google.com> writes:
> On Wed, May 27, 2015 at 11:51 AM, Justin Bogner <mail at justinbogner.com> wrote:
>
>> Is setting the comdat on Data sufficient, or should we do it for
>> Counters (and possibly even name) also? I guess that could lead to some
>> more space savings, even if it doesn't have a visible effect.
>
> It's sufficient, but good point about the space savings.  I'll add them.
>
>> We usually wrap comments a little wider than this, and there's no need
>> to refer to the bug number here.
>
> Really?  Wow, OK.  I find these references very valuable for future
> archaeology. But, sure, I'll remove it.
>
> I guess, leaving a reference to it in the commit log is OK?

Yep, the commit log's the right place for bug references. They're easy
enough to find with git blame on the comment or the line in question
that way :)

>
> Diego.



More information about the llvm-commits mailing list