[PATCH] [sanitizer] Decorate /proc/self/maps.

Alexey Samsonov vonosmas at gmail.com
Tue May 26 17:16:33 PDT 2015


================
Comment at: test/msan/decorate_proc_maps.cc:1
@@ +1,2 @@
+// RUN: %clangxx_msan -g %s -o %t
+// RUN: MSAN_OPTIONS=decorate_proc_maps=1 %run %t 2>&1 | FileCheck %s
----------------
eugenis wrote:
> samsonov wrote:
> > I'd really prefer to have the test under test/sanitizer_common. If needed, we may introduce CHECK-%SAN substitution to combine `CHECK-ASAN:`, `CHECK-MSAN:` and `CHECK-TSAN:` in the same file.
> And CHECK-MSAN-ORIGINS:, too?
> Ideally, we should allow any CHECK-XXX to be split into CHECK-XXX-%SAN. I don't think it is possible with lit.
> 
Yeah, origins mode is a problem... As for CHECK-XXX, you can pass several `--check-prefix` flags to `FileCheck`, so that `FileCheck --check-prefix=CHECK-XXX --check-prefix=CHECK-%san-XXX` would check for both common and sanitizer-specific parts.

================
Comment at: test/utils/utils.h:1
@@ +1,2 @@
+#include <sys/types.h>
+#include <sys/stat.h>
----------------
either indicate that it's linux/posix specific in the file name, or guard all platform-specific code with ifdefs.

http://reviews.llvm.org/D10039

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list