[lld] r238115 - [ELF] Fix lld when no unique sections is used

[Sean Silva]

On Tue, May 26, 2015 at 3:16 PM, Michael Spencer <bigcheesegs at gmail.com>
wrote:

> On Tue, May 26, 2015 at 2:18 PM, Rui Ueyama <ruiu at google.com> wrote:
> > Yes we should fix it if it can't handle valid objects, but I think we
> > probably start considering checking in object files (as opposed to
> checking
> > in yaml files) is the right thing, as IIRC Rafael said before. Object
> files
> > are the input for the linker, so in order to get a precise control over
> the
> > input, it's better to use object files themselves.
>
> I would rather we not use non-human readable inputs for testing. It
> makes it difficult to tell what's being tested and what the file
> actually represents. The intent of yaml2obj is to be able to represent
> (almost) any valid ELF file, and some invalid ones. I'll add support
> for it.
>
>
As I describe at <
http://lists.cs.uiuc.edu/pipermail/llvmdev/2014-April/071921.html>, the
fundamental design question of yaml2elf is deciding on a tradeoff between
the subset of ELF files that can be represented and
readability/modifiability/learnability of the textual format.

Whether or not it is worth teaching yaml2elf and elf2yaml about non-unique
section names depends on how much the textual format needs to be changed
(and in what way) vs. the degree of need for representing non-unique
section names.

-- Sean Silva


> - Michael Spencer
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150526/4f736467/attachment.html>