[lld] r238115 - [ELF] Fix lld when no unique sections is used

Michael Spencer bigcheesegs at gmail.com
Tue May 26 15:16:11 PDT 2015


On Tue, May 26, 2015 at 2:18 PM, Rui Ueyama <ruiu at google.com> wrote:
> Yes we should fix it if it can't handle valid objects, but I think we
> probably start considering checking in object files (as opposed to checking
> in yaml files) is the right thing, as IIRC Rafael said before. Object files
> are the input for the linker, so in order to get a precise control over the
> input, it's better to use object files themselves.

I would rather we not use non-human readable inputs for testing. It
makes it difficult to tell what's being tested and what the file
actually represents. The intent of yaml2obj is to be able to represent
(almost) any valid ELF file, and some invalid ones. I'll add support
for it.

- Michael Spencer



More information about the llvm-commits mailing list