[PATCH] Use value semantics for list of ScopStmt(s) instead of std::owningptr

Tobias Grosser tobias at grosser.es
Tue May 26 14:52:40 PDT 2015


Hi jdoerfert, dblaikie,

David Blaike suggested this as an alternative to the use of owningptr(s) for our
memory management, as value semantics allow to avoid the additional interface
complexity caused by owningptr while still providing similar memory consistency
guarantees. We could also have used a std::vector, but the use of std::vector
would yield possibly changing pointers which currently causes problems as for
example the memory accesses carry pointers to their parent statements. Such
pointers should not change.

http://reviews.llvm.org/D10041

Files:
  include/polly/ScopInfo.h
  lib/Analysis/DependenceInfo.cpp
  lib/Analysis/ScopInfo.cpp
  lib/CodeGen/IRBuilder.cpp
  lib/CodeGen/Utils.cpp
  lib/Exchange/JSONExporter.cpp
  lib/Transform/ScheduleOptimizer.cpp

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D10041.26541.patch
Type: text/x-patch
Size: 16830 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150526/a5e83d28/attachment.bin>


More information about the llvm-commits mailing list