[PATCH] Support python in other than /usr/bin/python

Ed Maste emaste at freebsd.org
Tue May 26 13:16:48 PDT 2015


I'm happy to just switch to /usr/bin/env python in the scripts if everyone's happy with that (leaving the explicit `PYTHON_EXECUTABLE` override as it was).


================
Comment at: lib/sanitizer_common/scripts/check_lint.sh:15
@@ +14,3 @@
+  if [ -x /usr/local/bin/python ]; then
+    PYTHON_EXECUTABLE=/usr/local/bin/python
+  elif PYTHON_EXECUTABLE=$(which python 2>/dev/null); then
----------------
samsonov wrote:
> You never set PYTHON_EXECUTABLE to /usr/bin/python, is it intentional, or you believe it would always be in PATH in this case?
If it's in /usr/bin/python the `PTYHON_EXECUTABLE` can remain empty and `#!/usr/bin/python` at the beginning of the python scripts will take effect.

http://reviews.llvm.org/D9914

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list