[PATCH] Disable DAGCombine for -O0 and optnone
Paul Robinson
Paul_Robinson at playstation.sony.com
Tue May 26 12:28:15 PDT 2015
I had one inline comment about how to test for the correct conditions.
I think the updated 'dag-optnone.ll' already covers everything that's in 'fastmath-optnone.ll' so you don't need to add the latter as a new test.
I'm not qualified to review all the other test changes, someone else will need to do that.
REPOSITORY
rL LLVM
================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:1204
@@ +1203,3 @@
+ !DAG.getMachineFunction().getFunction()->hasFnAttribute(
+ Attribute::OptimizeNone);
+
----------------
It should be sufficient to test OptLevel here. OptimizeNone should have reset OptLevel for the current function, so you should not need to check the attribute directly.
http://reviews.llvm.org/D9992
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list